--- In DynoMotion@yahoogroups.com, Tom Kerekes <tk@...> wrote:
>
> Kevin,
>
> Yes several bugs regarding applying/saving G92 offsets from the Edit Fixtures Screen.  Here are two files with changes that should fix them.
>
> Regards
> TK
>
>
>
> ________________________________
> From: fireup_kev <kliboon@...>
> To: DynoMotion@yahoogroups.com
> Sent: Wednesday, April 3, 2013 6:28 AM
> Subject: [DynoMotion] Re: V4.31b Fixture offset table not saved right
>
>
>  
> Ok, after I remove the values from default.set it kinda works. I can save the values for G92 if I use the Zero or Set button next to the DRO but can not change the values in the table directly like I can for G54 to G59.9 (but I think it's fine the way it is now, maybe remove the clear button for G92 since it cannot be clear that way)
>
> (you should also update the help...)
>
> Thanks,
> Kevin
>
> --- In DynoMotion@yahoogroups.com, TK <tk@> wrote:
> >
> > Hi Kevin,
> >
> > I think the code is working correctly but it is somewhat confusing.
> >
> > The current Interpreter State (including offsets) can be saved to the Vars File. The Setup File allows you to force the initial state of things to specific values.
> >
> > I think the default setup file - default.set - sets the xyz G92 offset to zero.
> >
> > If you would rather the offsets to be saved rather than set to specific values then remove the settings from the Setup File.
> >
> > Regards
> > TK
> >
> > On Apr 2, 2013, at 9:53 PM, "fireup_kev" <kliboon@> wrote:
> >
> > > Tom,
> > >
> > > That fixed the offset table for G54 to G59.9, but the global G92 offset is not being saved. Is this intentional or should that be saved also?
> > >
> > > Thanks,
> > > Kevin
> > >
> > > --- In DynoMotion@yahoogroups.com, Tom Kerekes <tk@> wrote:
> > > >
> > > > Hi Kevin,
> > > >
> > > > Right again. In GCodeInterpreter.dll file driver.cpp
> > > >
> > > > this
> > > >
> > > > int index = settings->origin_index;
> > > > Vars[5221+index*20] = settings->origin_offset_x;
> > > > Vars[5222+index*20] = settings->origin_offset_y;
> > > > Vars[5223+index*20] = settings->origin_offset_z;
> > > > Vars[5224+index*20] = settings->AA_origin_offset;
> > > > Vars[5225+index*20] = settings->BB_origin_offset;
> > > > Vars[5226+index*20] = settings->CC_origin_offset;
> > > >
> > > > should be
> > > >
> > > > int index = settings->origin_index;
> > > > Vars[5201+index*20] = settings->origin_offset_x;
> > > > Vars[5202+index*20] = settings->origin_offset_y;
> > > > Vars[5203+index*20] = settings->origin_offset_z;
> > > > Vars[5204+index*20] = settings->AA_origin_offset;
> > > > Vars[5205+index*20] = settings->BB_origin_offset;
> > > > Vars[5206+index*20] = settings->CC_origin_offset;
> > > >
> > > >
> > > > I have also attached the changed file.
> > > >
> > > > Regards
> > > > TK
> > > >
> > > >
> > > >
> > > > ________________________________
> > > > From: fireup_kev <kliboon@>
> > > > To: DynoMotion@yahoogroups.com
> > > > Sent: Tuesday, April 2, 2013 5:21 PM
> > > > Subject: [DynoMotion] V4.31b Fixture offset table not saved right
> > > >
> > > >
> > > >
> > > > Seems like the Fixture offset table added in V4.31b is not being saved right. G54 and G55 seem to corrupted each others data.
> > > >
> > >
> > >
> >
>

--- In DynoMotion@yahoogroups.com, "fireup_kev" <kliboon@...> wrote:
>
> So far so good with these updates. Can we make a V4.31c so I have an install version with all the latest changes?
>
> --- In DynoMotion@yahoogroups.com, Tom Kerekes <tk@> wrote:
> >
> > Kevin,
> >
> > Yes several bugs regarding applying/saving G92 offsets from the Edit Fixtures Screen.  Here are two files with changes that should fix them.
> >
> > Regards
> > TK
> >
> >
> >
> > ________________________________
> > From: fireup_kev <kliboon@>
> > To: DynoMotion@yahoogroups.com
> > Sent: Wednesday, April 3, 2013 6:28 AM
> > Subject: [DynoMotion] Re: V4.31b Fixture offset table not saved right
> >
> >
> >  
> > Ok, after I remove the values from default.set it kinda works. I can save the values for G92 if I use the Zero or Set button next to the DRO but can not change the values in the table directly like I can for G54 to G59.9 (but I think it's fine the way it is now, maybe remove the clear button for G92 since it cannot be clear that way)
> >
> > (you should also update the help...)
> >
> > Thanks,
> > Kevin
> >
> > --- In DynoMotion@yahoogroups.com, TK <tk@> wrote:
> > >
> > > Hi Kevin,
> > >
> > > I think the code is working correctly but it is somewhat confusing.
> > >
> > > The current Interpreter State (including offsets) can be saved to the Vars File. The Setup File allows you to force the initial state of things to specific values.
> > >
> > > I think the default setup file - default.set - sets the xyz G92 offset to zero.
> > >
> > > If you would rather the offsets to be saved rather than set to specific values then remove the settings from the Setup File.
> > >
> > > Regards
> > > TK
> > >
> > > On Apr 2, 2013, at 9:53 PM, "fireup_kev" <kliboon@> wrote:
> > >
> > > > Tom,
> > > >
> > > > That fixed the offset table for G54 to G59.9, but the global G92 offset is not being saved. Is this intentional or should that be saved also?
> > > >
> > > > Thanks,
> > > > Kevin
> > > >
> > > > --- In DynoMotion@yahoogroups.com, Tom Kerekes <tk@> wrote:
> > > > >
> > > > > Hi Kevin,
> > > > >
> > > > > Right again. In GCodeInterpreter.dll file driver.cpp
> > > > >
> > > > > this
> > > > >
> > > > > int index = settings->origin_index;
> > > > > Vars[5221+index*20] = settings->origin_offset_x;
> > > > > Vars[5222+index*20] = settings->origin_offset_y;
> > > > > Vars[5223+index*20] = settings->origin_offset_z;
> > > > > Vars[5224+index*20] = settings->AA_origin_offset;
> > > > > Vars[5225+index*20] = settings->BB_origin_offset;
> > > > > Vars[5226+index*20] = settings->CC_origin_offset;
> > > > >
> > > > > should be
> > > > >
> > > > > int index = settings->origin_index;
> > > > > Vars[5201+index*20] = settings->origin_offset_x;
> > > > > Vars[5202+index*20] = settings->origin_offset_y;
> > > > > Vars[5203+index*20] = settings->origin_offset_z;
> > > > > Vars[5204+index*20] = settings->AA_origin_offset;
> > > > > Vars[5205+index*20] = settings->BB_origin_offset;
> > > > > Vars[5206+index*20] = settings->CC_origin_offset;
> > > > >
> > > > >
> > > > > I have also attached the changed file.
> > > > >
> > > > > Regards
> > > > > TK
> > > > >
> > > > >
> > > > >
> > > > > ________________________________
> > > > > From: fireup_kev <kliboon@>
> > > > > To: DynoMotion@yahoogroups.com
> > > > > Sent: Tuesday, April 2, 2013 5:21 PM
> > > > > Subject: [DynoMotion] V4.31b Fixture offset table not saved right
> > > > >
> > > > >
> > > > >
> > > > > Seems like the Fixture offset table added in V4.31b is not being saved right. G54 and G55 seem to corrupted each others data.
> > > > >
> > > >
> > > >
> > >
> >
>